From ee7fc3fc4ea6ccc99d7d51389db5730009123d1d Mon Sep 17 00:00:00 2001 From: Arthur Deierlein Date: Fri, 12 Apr 2024 14:15:45 +0200 Subject: [PATCH 1/3] chore(ci): remove schedule from test.yaml --- .github/workflows/test.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 2ab8da12..8441c9b9 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -4,8 +4,6 @@ name: Test on: push: pull_request: - schedule: - - cron: "0 0 * * 0" jobs: test: From 131857a731d13bddcaad6552b6aa614808e6a155 Mon Sep 17 00:00:00 2001 From: Arthur Deierlein Date: Fri, 12 Apr 2024 14:17:57 +0200 Subject: [PATCH 2/3] chore(ci): use run instead of exec in test.yaml --- .github/workflows/test.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 8441c9b9..065850f2 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -22,8 +22,8 @@ jobs: docker-compose up -d --build backend - name: Lint the code run: | - docker-compose exec -T backend black --check . - docker-compose exec -T backend flake8 - docker-compose exec -T backend python manage.py makemigrations --check --dry-run --no-input + docker-compose run --rm backend black --check . + docker-compose run --rm backend flake8 + docker-compose run --rm backend python manage.py makemigrations --check --dry-run --no-input - name: Run pytest - run: docker-compose exec -T backend pytest --no-cov-on-fail --cov --create-db -vv + run: docker-compose run --rm backend pytest --no-cov-on-fail --cov --create-db -vv From 7768da14a4e198998b1946ef6bca05d505377c0d Mon Sep 17 00:00:00 2001 From: Arthur Deierlein Date: Fri, 12 Apr 2024 14:20:36 +0200 Subject: [PATCH 3/3] chore(ci): make checking for missing migrations a step --- .github/workflows/test.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 065850f2..b81e68e0 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -24,6 +24,7 @@ jobs: run: | docker-compose run --rm backend black --check . docker-compose run --rm backend flake8 - docker-compose run --rm backend python manage.py makemigrations --check --dry-run --no-input + - name: Check for missing migrations + run: docker-compose run --rm backend python manage.py makemigrations --check --dry-run --no-input - name: Run pytest run: docker-compose run --rm backend pytest --no-cov-on-fail --cov --create-db -vv