Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning an SSML document turns it into GRXML #26

Closed
sfgeorge opened this issue Apr 1, 2014 · 3 comments
Closed

Cloning an SSML document turns it into GRXML #26

sfgeorge opened this issue Apr 1, 2014 · 3 comments

Comments

@sfgeorge
Copy link
Member

sfgeorge commented Apr 1, 2014

If you draw a new SSML document and then clone it, the clone has the right XML content but is a RubySpeech::GRXML::Element. As a result, you cannot embed this document into another SSML document. This is shown in the following tests: sfgeorge/ruby_speech@50c5a4a.

It seems that cloning any GenericElements is designed to always produce GRXML document. Cloning an SSML doc should result in another SSML doc.
@benlangfeld
Copy link
Member

Could you submit those tests as a pull request? This is most definitely a mistake :)

@sfgeorge
Copy link
Member Author

sfgeorge commented Apr 1, 2014

You bet, added as #27. Thanks!

@Jared-Prime Jared-Prime mentioned this issue Apr 21, 2014
Merged
@benlangfeld
Copy link
Member

This was fixed by #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfgeorge @benlangfeld