Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment detector too sensitive, detects # in urls as comments #1

Open
mattbloomfield opened this issue May 21, 2018 · 2 comments
Open

Comments

@mattbloomfield
Copy link

mattbloomfield commented May 21, 2018

I know this is old but maybe it will help someone else

Consider redirects to AngularJS urls: /my/app/#/page1

I worked around this by modifying the code to, which works in my use case and just forces comments to be followed by a space:

// lib/parse.js
...
} else if (currentBuffer.slice(-2) == "# ") {
                commentHandler.init(token);
...
@adiktofsugar
Copy link
Owner

well, after looking at the current code, i'm pretty sure i'll change it a fair amount if i get into it, and i'll probably use nginx-conf as a backend, which is definitely a more mature project. I do like how mine is kinda jquery like, though, so i'll keep that aspect of it but more as a wrapper around the nginx-conf package.

@mattbloomfield
Copy link
Author

Yeah, in my case I'm using a hybrid of both of the projects as I wanted something where I could pull the directives out and edit them in a web form and then compile them back to a config file on the server end. Maybe I'll write a new package dependent on both this and nginx-conf! Oh the world of NPM haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants