Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Mode 1 & 2 #223

Open
savagesmc opened this issue Oct 12, 2022 · 4 comments
Open

Compatibility Mode 1 & 2 #223

savagesmc opened this issue Oct 12, 2022 · 4 comments

Comments

@savagesmc
Copy link

I have a model that currently uses compatibility mode 1, but am emulating a waveform that operates with negative signal to noise ratios. The Phy is dropping my packets due to sensitivity, well before my emulated receiver would stop receiving them in our real radios. I enabled the "rxsensitivitypromiscuousmodeenable" parameter in the phy, but much to my chagrin, it appears that parameter is only honored when compatibility mode is 2. Is there a reason why it wouldn't be appropriate to just skip the compatibility mode check on that line where it is used? I am going to make a pull request with that small change, so that I can continue my testing. Hopefully this is something that could be merged in.

@sgalgano
Copy link
Member

rxsensitivitypromiscuousmodeenable does not do what you think it does. Set the physical layer systemnoisefigure parameter accordingly to adjust to your desired receiver sensitivity.

@savagesmc
Copy link
Author

Thank you for responding so quickly. I originally tried what you suggested, I changed the systemnoisefigure to something crazy like -30, and then the SINRs that resulted seemed to be off by roughly that amount. Do I just correct the SINR that gets computed by the amount systemnoisefigure is off from the real noise figure? For example, if my real NF is 4, and I put 30 in, would I just adjust the computed SINR down by 34 dB?

@sgalgano
Copy link
Member

Only reduce the noise component by that amount in the SINR (Signal/(Interference + Noise)) calculation within the radio model implementation. Keep in mind the spectrum window energy values are in mW, so make sure you are adding or subtracting mW.

@savagesmc
Copy link
Author

savagesmc commented Oct 13, 2022

That worked. You can close this issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants