Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: omitted 'registration' parameter of State Resource #1086

Open
sir-sigurd opened this issue Mar 12, 2019 · 1 comment
Open

question: omitted 'registration' parameter of State Resource #1086

sir-sigurd opened this issue Mar 12, 2019 · 1 comment

Comments

@sir-sigurd
Copy link

When registration parameter is omitted the behavior of State Resource is not quite clear for me.

For example when Multiple Document DELETE with omitted registration is requested, does it delete all States for the specified activityId and agent or just States that were created with no registration specified?

@garemoko
Copy link
Contributor

That's an interesting question and I agree that as the spec currently reads, this is ambiguous not just for multiple document delete, but also for multiple document get and for single document get and delete. We should update this to make it clearer.

The way Watershed LRS implements this, which I believe is what was intended, is that 'no registration' is treated as if it is itself a registration. So if you send a GET or DELETE request with no registration, you will only get or delete state documents that were stored with no registration.

For single document GET at least, this seems to be the only practical interpretation since the expected response is a single document, and if the intention was that the LRS should return documents with any registration, that could be multiple documents. And if we take that interpretation for single document GET, that pushes us towards the same interpretation for multiple document GET and for single/multiple document DELETE. (Single document DELETE is also implied to only affect a single document).

But yes, it definitely could be made clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants