Added env variable support for himl #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amuraru
reviewed
Jul 13, 2021
amuraru
reviewed
Jul 13, 2021
amuraru
reviewed
Jul 13, 2021
amuraru
reviewed
Jul 13, 2021
| return line | ||
|
|
||
| # remove {{ and }} | ||
| updated_line = line[2:-2] |
There was a problem hiding this comment.
What about: key: "prefix-{{env(VAR)}}-suffix" ?
There was a problem hiding this comment.
Do we want to offer support for interpolation with prefix/suffix with environment variables? I was thinking something more similar to the secret resolvers
|
also a big gap in him is the lack of unit-tests. /cc @danielcoman |
amuraru
reviewed
Jul 14, 2021
amuraru
approved these changes
Jul 14, 2021
alungu
approved these changes
Jul 14, 2021
costimuraru
reviewed
Jul 21, 2021
costimuraru
reviewed
Jul 21, 2021
costimuraru
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to bring support to Himl for including environment variables when interpolating.
Description
Added support for HIML to use env variables when interpolating the hierarchy.
Related Issue
Resolves #52
Motivation and Context
See description. Also can be used to include build-time variables in a HIML structure.
How Has This Been Tested?
Tested out by adding a field in one of the examples with
Types of changes
Checklist: