Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest.json path format specification #24

Open
hirenoble opened this issue Jul 28, 2020 · 0 comments
Open

Manifest.json path format specification #24

hirenoble opened this issue Jul 28, 2020 · 0 comments
Assignees

Comments

@hirenoble
Copy link
Contributor

Expected Behaviour

If the path in the manifest.json file is defined, missing out the branch name as org_name/repo_name/mdfile.md or org_name/repo_name/folder/mdfile.md this should be handled at Parliament side considering the branch name specified in an environment variable.

Actual Behaviour

Since we try to match the pattern org_name/repo_name/branch for gitRemote info to validate the path and create a slug the above scenario fails.

Reproduce Scenario (including but not limited to)

Change a working path to org_name/repo_name/mdfile.md removing the branch reference.

Steps to Reproduce

Change a working path to org_name/repo_name/mdfile.md removing the branch reference.

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants