fix: update to latest data-access, process response status

package.json

@@ -55,7 +55,7 @@
     "@adobe/helix-shared-wrap": "2.0.0",
     "@adobe/helix-status": "10.0.10",
     "@adobe/helix-universal-logger": "3.0.11",
-    "@adobe/spacecat-shared-data-access": "1.1.2",
+    "@adobe/spacecat-shared-data-access": "1.1.3",
     "@adobe/spacecat-shared-utils": "1.2.0",
     "@aws-sdk/client-sqs": "3.450.0",
     "diff": "5.1.0"

src/support/github-client.js

@@ -125,12 +125,10 @@ function GithubClient(
       });
 
       let responseJson;
-      try {
-        const text = await response.text();
-        log.info(`Parsing GitHub response for site ${baseURL}: \n ${text}`);
-        responseJson = JSON.parse(text);
-      } catch (error) {
-        log.error(`Error parsing GitHub response for site ${baseURL}: ${error}`);
+      if (response.status === 200) {
+        responseJson = await response.json();
+      } else {
+        log.error(`Error fetching GitHub diff data for site ${baseURL}: ${response.status} ${response.statusText}`);
         return '';
       }
 

test/support/github-client.test.js

@@ -110,7 +110,7 @@ describe('GithubClient', () => {
       nock('https://api.github.com')
         .get('/repos/some-org/test/commits')
         .query(true)
-        .reply(200, 'invalid-response');
+        .reply(405);
 
       const diffs = await client.fetchGithubDiff('example.com', audit.time, lastAuditedAt, gitHubURL);
       expect(diffs).to.equal('');