feat: introduce Opportunity creation for Broken Backlinks #475
+646
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
habansal
reviewed
Nov 22, 2024
habansal
reviewed
Nov 22, 2024
# Conflicts: # package-lock.json # package.json
habansal
reviewed
Nov 26, 2024
solaris007
reviewed
Nov 27, 2024
ekremney
reviewed
Nov 28, 2024
| @@ -216,3 +216,50 @@ export default new AuditBuilder() | |||
| .build(); | |||
|
|
|||
| ``` | |||
|
|
|||
| ### How to add Opportunities and Suggestions | |||
# Conflicts: # package-lock.json
ekremney
approved these changes
Nov 28, 2024
habansal
reviewed
Nov 29, 2024
| const newDataKeys = new Set(newData.map(buildKey)); | ||
| const existingSuggestions = await opportunity.getSuggestions(); | ||
|
|
||
| // Remove outdated suggestions |
There was a problem hiding this comment.
If the existing suggestion was entered via back-office-ui as the source, we should NOT delete it, irrespective of whether the same suggestion exists in the new audit or not
There was a problem hiding this comment.
We will handles this as a next step. This will require an additional property in the data model
habansal
reviewed
Nov 29, 2024
solaris007
approved these changes
Nov 29, 2024
habansal
approved these changes
Nov 29, 2024
solaris007
pushed a commit
that referenced
this pull request
Nov 29, 2024
# [1.36.0](v1.35.0...v1.36.0) (2024-11-29) ### Features * introduce Opportunity creation for Broken Backlinks ([#475](#475)) ([78ce9a3](78ce9a3))
|
🎉 This PR is included in version 1.36.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.