Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Research]: Toast timeout minimum differs from design docs #4939

Open
1 task done
caseyisonit opened this issue Nov 19, 2024 · 1 comment
Open
1 task done

[Bug/Research]: Toast timeout minimum differs from design docs #4939

caseyisonit opened this issue Nov 19, 2024 · 1 comment
Labels
needs jira ticket triage An issue needing triage

Comments

@caseyisonit
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Description of issue

Need confirmation on truth
Toast design specs state that the minimum for "auto-dismissible" (timeout) should be a minimum of 5s (5000ms)
Toast web component storybook sets the minimum to 6s (6000ms) in the timeout if any number under 6000 is provided.

Also there is additional accessibility notes about word count and adding time. Where can i find that specific documentation?

Quick fix:

  • Update the docs or the timeout minimum to align

Future version improvement:
Should we programmatically set the timeout time based on word count from the content slot? I ask this because its odd to be able to set a property value under 6000ms and it be defaulted to that. Gives me a dark pattern vibe i dont like.

i.e. the property type could be boolean like defined in the design docs and the consumer doesnt have to be concerned with timing values, that comes for free with our accessibility requirements (note: this is a change to the API and would be something to consider for V2.0)

@caseyisonit caseyisonit added triage An issue needing triage needs jira ticket labels Nov 19, 2024
@caseyisonit
Copy link
Collaborator Author

Slack convo started here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs jira ticket triage An issue needing triage
Projects
None yet
Development

No branches or pull requests

1 participant