Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent API for quiet and other variants. #4945

Open
1 task done
nikkimk opened this issue Nov 21, 2024 · 0 comments
Open
1 task done

Consistent API for quiet and other variants. #4945

nikkimk opened this issue Nov 21, 2024 · 0 comments
Labels
needs jira ticket triage An issue needing triage

Comments

@nikkimk
Copy link
Contributor

nikkimk commented Nov 21, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Description of issue

On <sp-action-menu>, quiet styling is set with the quiet boolean property but, on <sp-card> quiet styling is set via variant="quiet". This feels like an inconsistency in our API. We should review how we're applying quiet and other variants across our components and work toward some consistency.
@nikkimk nikkimk added triage An issue needing triage needs jira ticket labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs jira ticket triage An issue needing triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikkimk