Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefly site showed the Watch Live button in the navigation #108

Open
kunwarsaluja opened this issue Jul 23, 2024 · 5 comments
Open

Firefly site showed the Watch Live button in the navigation #108

kunwarsaluja opened this issue Jul 23, 2024 · 5 comments

Comments

@kunwarsaluja
Copy link
Collaborator

Firefly site showed the Watch Live button in the navigation

Screenshot 2024-07-23 at 4 20 15 PM

@kunwarsaluja
Copy link
Collaborator Author

@tom-hightower do you know the conditions on when this Watch Live button appears on the homepage navigation ?
I don't see any styling for this on the Figma file ?

@tom-hightower
Copy link
Collaborator

This is controlled by the firefly-live-event feature flag

@kunwarsaluja
Copy link
Collaborator Author

kunwarsaluja commented Jul 25, 2024

@kailasnadh790 another one to tackle later using feature flags.

@tom-hightower Are there anymore such unknowns we are not aware of or totally missing but are being driven by feature flags and we should account for them on the homepage ?

@tom-hightower
Copy link
Collaborator

There are several features that are feature flag driven, I'm not sure which ones you're aware of. Example:

  • "plg-upsell-navbar-button": Whether to show the persistent "upgrade" button in the top nav (in conjunction with premium user and logged in state)
  • "firefly-homepage-auto-scroll": Whether the module carousel automatically scrolls/wraps (disabled, remains togglable "just in case", you can safely ignore)
  • "firefly-clio-feedback-module": Whether to show the feedback module (in conjunction with non-K12, en-US locale, and adobe accounts (federated enterprise))

Is your current awareness based on the <Home /> and <Navbar /> components in the current homepage section of our codebase? I think that this is probably the best way to check the display logic

@kunwarsaluja
Copy link
Collaborator Author

Thanks @tom-hightower this is helpful. We were not aware of all these cases so now considering these 1:1 basis for the MVP.

We missed you in the last meeting but we did request Daosheng/Sarah to help us here to move in the right direction for all such use-cases which are not accounted in the figma file or embedded deep in the code and also provide an api/library which is readily consumable for identifying a user state (personal/enterprise profile, entitlements, these extra feature flags) and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants