Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery] Gallery tab header content #69

Open
tom-hightower opened this issue Jun 14, 2024 · 6 comments
Open

[Gallery] Gallery tab header content #69

tom-hightower opened this issue Jun 14, 2024 · 6 comments
Labels

Comments

@tom-hightower
Copy link
Collaborator

  • Font size/weight
  • Subtitle info icon with tooltip
  • "View your submissions" button

Firefly:
image

Franklin:
image

@kunwarsaluja
Copy link
Collaborator

fixed with #84

@tom-hightower
Copy link
Collaborator Author

This doesn't appear to be fixed. The font size/weight, subtitle info icon with tooltip, and "view your submissions" button are all still issues. Additionally, it looks like the top nav doesn't display on the gallery page?

image

@tom-hightower tom-hightower reopened this Jun 26, 2024
@kunwarsaluja
Copy link
Collaborator

kunwarsaluja commented Jun 26, 2024

@tom-hightower are we looking at the same page ? Can you review https://main--firefly--adobecom.hlx.page/community and let me know what are we missing and I can fix those for you.

Other thing I noticed, where are these strings coming from ?

  1. Discover Firefly prompts to remix and submit your own images to the gallery. (I found something close here but not the same string)
  2. As you create with Text to image, use the Share button to make submissions. (tooltip text)

I don't see them in the en-US.json dictionary ? Are these Hardcoded strings ?

@tom-hightower
Copy link
Collaborator Author

Oh sorry, I was looking at the https://main--firefly--adobecom.hlx.live/community version. What is the difference between this and the .page version?

The version you linked is closer, but still doesn't match the existing live site. The main issues I see are the spacing, color theming, content (strings that the community gallery team use are here), and that the "View your submissions" should only appear for a logged in user.
Firefly:
image

Franklin:
image

@kunwarsaluja
Copy link
Collaborator

@tom-hightower
.live is the final published version and .page is more like preview before we actually publish it.

Spacing and other things are easy fixes and can deal with them tomorrow morning.

Localized content now in community git repo altogether makes things a bit weird as we were piggybacking on en-us and other localized json in spl-webclient repo as a single source of truth but now we have a new repo that has different set of localized json that too just for the community page wondering if we should create a manual spreadsheet with key value pairs of strings currently being used on homepage and community page rather than trying to reuse the localized jsons from both these repos. Opinions ? Suggestions ?

@kailasnadh790 For the ‘view submission’ button, is there a helper function that we use to check if the user is logged in or not?

@kunwarsaluja
Copy link
Collaborator

@tom-hightower Putting this issue on hold until we have clarity if firefly team wants to take just the homepage or both homepage + community page on the new platform. Will pick this up when we have clear direction on that.

@kunwarsaluja kunwarsaluja removed their assignment Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants