Should we expand the PR template

[mokimo]

Current limitations

The current PR template is very generic https://github.com/adobecom/milo/blob/main/.github/pull_request_template.md and runs into some limitations as the ecosystem grows and it takes time to always create a meaningful PR quickly.

Context

The Eurovision team had some internal discussions and we wanted to create an enhanced PR template for us #1213 - that brings the question if the whole milo community could profit from this.

We decided to create a template for our purposes as we ran into difficulties thoroughly testing code changes (adobe.com -> has a .html ending, localisation, different projects...) without too much overhead of us trying to find the correct links on each PR

Proposal

This might benefit the larger milo community:

• Every PR should have a description - 1-2 sentences about what it tries to achieve
• Every PR should add test instructions.
  • Certain tools require auth, VPNs, complex set up to get things running
  • Describe all the necessary steps so a reviewer can test that the PR achieves what it wants to
• Provide Context (Jira, old PRs, related PRs, etc.)
• Enhance Test URLs
  • This might be tricky, for the GNAV we can simply pick a few consumer sites - for certain blocks that's not that easy and might need creating extra pages.

I wonder what the thoughts of the community are around this topic! I always find myself spending a lot of time trying to copy my personal "template" for previous PRs

[mokimo]

If we decide on a new template for the milo core repo, we should create a few common test-pages across consumers that feature the most important (or even all) blocks which can be re-used across PRs, so that each dev spends less time on trying to fill a PR description

[overmyheadandbody]

Seems there isn't any interest in this, so I'll resolve the topic.

For Gnav purposes, we've created a new template in .github/PULL_REQUEST_TEMPLATE/gnav.md. Whenever we compare two branches, we can simply add &template=gnav.md to the URL and our specific template will be used. That template contains test URL patterns for all clouds so we can ensure we're not introducing any issues with the proposed changes from the PR.