Replies: 1 comment 1 reply
-
+1 to the Page Metadata option. These pages are special cases and we should indicate that those are special. I wonder if there are any other features that could face similar issues? Localized links should still be okay, MEP maybe? Where they'd switch out english parts for localized parts? It's currently overall not a use-case we support, I'm not sure if there are enough of those pages to warrant exceptions or a big strategy either 🤔 A metadata flag to start out with for placeholders would be a good option. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In some locales, there are pages that remain in English, e.g., see (1). On these pages, localized placeholder keys are still being loaded, resulting in a mix of English content and localized placeholder text. This issue can be observed at (1), where the page itself is in English, but the placeholder texts are localized.
Potential Solutions
Disable Localized Placeholders for Non-Localized Pages:
One approach could be to ensure that Milo does not load localized placeholder keys if the page itself is not localized. However, implementing this change could potentially break existing pages that rely on the current behavior.
Page Metadata Configuration:
Another option is to allow authors to control this behavior by adding a specific metadata configuration to the page. This way, authors can explicitly decide whether or not to load localized placeholders, depending on the content of the page.
Other Options?
Are there alternative approaches we should consider to address this issue?
References
Beta Was this translation helpful? Give feedback.
All reactions