Replies: 3 comments 9 replies
-
Is core idea here to have as content a link (that would get to OST when editing things up), that gets converted to appropriate placeholder once rendered? |
Beta Was this translation helpful? Give feedback.
-
Thanks @vhargrave Regarding this question: "I'm wondering if it's too much to expect from an author to copy the OSI out of the link they'd have for a price, and place it as a param into the CTA link" I think we should avoid copying and pasting OSIs if possible. We try to stay away from authoring any type of IDs, as it's error prone and can be time consuming |
Beta Was this translation helpful? Give feedback.
-
I think a link block is the perfect solve for all pricing related features... inline, etc. For solves like cards, the layout and corresponding text should be an area of concern for the content surrounding the pricing bits (including terms, VAT, etc.) Ideally, we should have a service that can get all price information (price, currency, vat, terms, etc.) for a given area in one go. This would mean that a single card would only need one request even though the pricing bits may be in different parts of the card. |
Beta Was this translation helpful? Give feedback.
-
I've been pondering how we want to set prices and buttons coming from M@S, once the OST branch is merged
With the OST we can now generate a link that contains the OSI for a product and the priceType. With these two pieces of information I can build a price in Milo.
I'm wondering if it makes sense to build a global approach for converting these OST links to prices. The approach would look like this - in the decorateLinks method of utils.js file, we're already doing things on every link in the document. I propose that we add an additional check for if the href contains something like "tools/ost?osi=". If they do , then we convert this link into a span containing the price. We'd use tacocat to do the conversion.
For the CTA buttons (Buy now for example) I'd take a similar approach. I need an OSI so that tacocat creates a link that points to the right location the user should be taken on a click.
To set the OSI, I'm wondering if it's too much to expect from an author to copy the OSI out of the link they'd have for a price, and place it as a param into the CTA link. So the link would be adobe.com/?osi=OSIFromThePriceLink
If we don't go for that, I'll need another way to mark the CTA buttons so that the "nearest" OSI is used by tacocat to calculate its href.
I've taken this approach here btw, just not changing the links on global level. Instead I'm doing it all in the cards block -
https://vhargrave-poc-usage-merch--milo--adobecom.hlx.page/fragments/vhargrave/commerce-carddemo-5/offer-card-photography
https://adobe.sharepoint.com/:w:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7B4B5CA3E8-57C0-456C-A0B1-A2DCABDCFFE2%7D&file=offer-card-photography.docx&action=default&mobileredirect=true&cid=a047cc80-5d2b-40a9-8a0b-dc442466865e
Curious what you guys think .
Beta Was this translation helpful? Give feedback.
All reactions