Update on PR labels

[chrischrischris]

The milo team has made some changes to PR labels and how they should be used.

First off, the amount of labels is pretty large so I've deleted any labels that had < 5 uses.

There are two new labels that every developer should be aware of:

• new-feature : Anytime a new block, tool or feature is being submitted this label should be used. This label will trigger a milo email announcing the addition of the feature.
• high-impact : Any change that will affect Milo consumers. This also will send out an email. Note that this doesn't have to be a breaking change, just anything that we want to make sure consumers are aware of.

ALL Milo devs should sign up to grp-milo-dev as all high-impact emails will go there. new-feature goes to grp-milo-release.

The release label has been removed as it is replaced by the two labels above.

Project Labels:

In general project labels should not be created unless it's a very big task. Examples are Commerce & Gnav.

Please do not create a label for a specific block or small feature, we want to keep the list short. As long as the dev includes the block name in the title or description, we can easily filter the PRs with a text search.

Thanks!

• Milo Team

[chrischrischris]

Also when using new-feature be mindful that the audience is not just devs. The top of your PR description should describe in detail what the feature is in non-dev language. Dev notes can be added below that.

new-feature doesn't have to be a new feature, enhancements or any PR you want authors to know about is fine.

Also to sign up to groups: https://iam.corp.adobe.com/

[chrischrischris]

Before any PR can be merged it must have a trivial or verified label added. Some teams have QE add the verified label, others allow PR reviewers and/or the author to add it. The labels mentioned above only relate to PR communication.

[chrischrischris]

FYI - https://github.com/adobecom/milo/wiki/PR-Labels has been updated with the latest info

[Ruchika4]

@chrischrischris there was PR merged with new variation of text block today #778 This PR has new-feature label. However I didn't received any email. I am subscribed to grp-milo-release and have received email in past, like for this PR I had received email.