Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embroider: Use of ember internals #739

Open
fsmanuel opened this issue Oct 29, 2023 · 0 comments
Open

Embroider: Use of ember internals #739

fsmanuel opened this issue Oct 29, 2023 · 0 comments

Comments

@fsmanuel
Copy link
Contributor

This topic got raise by @Pixelik in #733. I did some digging but figured I don't have enough knowledge about embroider. So all help is appreciated!

In an efford to have all the findings in one place, here is what I found:

The genesis of addon/-private/ember-internals.js:

So I have two assumptions:

  1. The internal import does not work for Embroider
  2. The internal import is stable since ember 3.13 and we no longer need the fallback implementations

Now my question is, how do we get the import embroider safe or even better remove it altogether? I found:

We already borrowed a lot of the changes in the qonto fork so if this solution is still recommended by the embroider team I would say we use require and refactor the internals like I proposed here: #735 (comment) (maybe we don't even need the fix from @Pixelik)

The same goes for import { meta } from '@ember/-internals/meta';

//cc @ef4 @gilest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant