You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We already borrowed a lot of the changes in the qonto fork so if this solution is still recommended by the embroider team I would say we use require and refactor the internals like I proposed here: #735 (comment) (maybe we don't even need the fix from @Pixelik)
The same goes for import { meta } from '@ember/-internals/meta';
This topic got raise by @Pixelik in #733. I did some digging but figured I don't have enough knowledge about embroider. So all help is appreciated!
In an efford to have all the findings in one place, here is what I found:
The genesis of
addon/-private/ember-internals.js
:import __EMBER_METAL__ from '@ember/-internals/metal/index';
So I have two assumptions:
Now my question is, how do we get the import embroider safe or even better remove it altogether? I found:
require
instead ofimport
to make Embroider happy qonto/ember-cp-validations#20We already borrowed a lot of the changes in the qonto fork so if this solution is still recommended by the embroider team I would say we use
require
and refactor the internals like I proposed here: #735 (comment) (maybe we don't even need the fix from @Pixelik)The same goes for
import { meta } from '@ember/-internals/meta';
//cc @ef4 @gilest
The text was updated successfully, but these errors were encountered: