Extended seeding #49
Merged
Extended seeding #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
extendoption (TRUEby default) to all seeding components, which will extend the seeding phase beyond the necessary minimum (maximum generation time) until the first date with three consecutive non-zero measurements (detects). This is to avoid sampling problems when the measurement time series starts with many non-detects. Moreover, infection numbers are generally quite low during such periods, so Rt estimation is anyway questionable.The PR also brings more detailed warnings if the estimated number of infections is too low or too large, and improves the automatic calibration of the load per case when using the
min_casesspecification.