Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in call to query when pool is full #28

Open
jmendezm opened this issue Mar 7, 2019 · 1 comment · Fixed by Nordix/eredis_cluster#26
Open

Error in call to query when pool is full #28

jmendezm opened this issue Mar 7, 2019 · 1 comment · Fixed by Nordix/eredis_cluster#26

Comments

@jmendezm
Copy link

jmendezm commented Mar 7, 2019

Avoid error in function eredis_cluster_pool_worker:query() when poolboy return full instead of a Worker PID because pool is full
jmendezm pushed a commit to jmendezm/eredis_cluster that referenced this issue Apr 5, 2019
FIX adrienmo#28
4417e82 
[ADD] logs
@jmendezm jmendezm mentioned this issue Apr 5, 2019
Open
zuiderkwast added a commit to zuiderkwast/eredis_cluster that referenced this issue Sep 17, 2020
@zuiderkwast
Retry when pool is full
6ed4bc8 
Fixes adrienmo#28 and obsoletes PR adrienmo#29.

Retry is implemented for query, but not for query_noreply. Perhaps it should.
zuiderkwast added a commit to zuiderkwast/eredis_cluster that referenced this issue Sep 17, 2020
@zuiderkwast
Retry when pool is full
868b6fb 
Fixes adrienmo#28 and obsoletes PR adrienmo#29.

Retry is implemented for query, but not for query_noreply. Perhaps it should.
@zuiderkwast zuiderkwast mentioned this issue Sep 17, 2020
Merged
zuiderkwast added a commit to zuiderkwast/eredis_cluster that referenced this issue Sep 17, 2020
@zuiderkwast
Retry when pool is full
900dfbc 
Fixes adrienmo#28 and obsoletes PR adrienmo#29.

Retry is implemented for query, but not for query_noreply. Perhaps it should.
zuiderkwast added a commit to Nordix/eredis_cluster that referenced this issue Sep 18, 2020
@zuiderkwast
Retry when pool is full
51f39d9 
Fixes adrienmo#28 and obsoletes PR adrienmo#29.

Retry is implemented for query, but not for query_noreply. Perhaps it should.
@zuiderkwast
Copy link

Actually, poolboy:transaction/2 is using poolboy:checkout/3 with Block = true. This means that the atom 'full' is not returned. Thus, I think this PR can be closed.

Instead, if the pool is full, the call to poolboy:transaction/2 is blocking. When it times out, it causes an exit:{timeout, {gen_server, call, _}} exception which is converted to {error, no_connection} by the try-catch in eredis_cluster_pool. This causes a refresh mappings and then a retry. The refresh mappings is unnecessary in this case. We have a fix for that here: Nordix#27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retry when pool is full zuiderkwast/eredis_cluster
2 participants
@zuiderkwast @jmendezm