Retry when pool is full #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes adrienmo#28 and obsoletes PR adrienmo#29. Retry is implemented for query, but not for query_noreply. Perhaps it should.
zuiderkwast
force-pushed
the
pool_full
branch
from
868b6fb to
900dfbc
Compare
|
Might be possible to test the flow aswell if a testcase sets ..but queries (which I think should cover the full case) might result in the same error as other faults, ie, |
|
Can we have a fakeredis which sleeps for some seconds when performing the query? Then we can have a pool size of 1 and two concurrent queries. |
|
sounds good, without the correction the second query should not be retried and fail I guess |
|
Nice! Lgtm |
bjosv
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes adrienmo#28 and obsoletes PR adrienmo#29.
Retry is implemented for query, but not for query_noreply. Perhaps it should.