You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why does this project have typescript in the name and uses .ts files when all the basic features & advantages of typescript aren't even used?
Could as well just call it GA4-Measurement-Protocol-Javascript or to be more precise GA4-Measurement-Protocol-ES4, since ES5+ features supported in all modern browsers and Node.js for almost 10 years haven't even been used
For starters we could set types on all the variables and functions.
Instead of having variables assigned in a main function by using this.varname we could use TS's class definition.
Then when you compile it via the tsc it would not only be type safe and friendly in source but also generate the usage definition files for you.
The text was updated successfully, but these errors were encountered:
Why does this project have typescript in the name and uses
.ts
files when all the basic features & advantages of typescript aren't even used?Could as well just call it
GA4-Measurement-Protocol-Javascript
or to be more preciseGA4-Measurement-Protocol-ES4
, since ES5+ features supported in all modern browsers and Node.js for almost 10 years haven't even been usedFor starters we could set types on all the variables and functions.
Instead of having variables assigned in a main function by using
this.varname
we could use TS'sclass
definition.Then when you compile it via the tsc it would not only be type safe and friendly in source but also generate the usage definition files for you.
The text was updated successfully, but these errors were encountered: