Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: In chapter editor, make deletions of chapters soft deletes until saved #3401

Closed
ZLoth opened this issue Sep 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ZLoth
Copy link

ZLoth commented Sep 11, 2024

Type of Enhancement

Web Interface/Frontend

Describe the Feature/Enhancement

When deleting chapters using the chapter editor, the deletions should be "soft deleted" until saved so that deletion can be undone. Deleted chapters should have the input boxes removed, the text of both the runtime and chapter name are modified to use the strikethough HTML tag, and possibly changing the color from while to another color. If you click the minus sign again, then the change is undone, and the input boxes are restored.

Why would this be helpful?

As currently designed, the chapter editor is a "hard delete" which means that once the chapter is deleted, it cannot be undeleted unless you refresh the page. This can be a problem if I'm deleting duplicate chapters and hit the minus sign one-too-many times.

Future Implementation (Screenshot)

image

Audiobookshelf Server Version

v2.13.4

Current Implementation (Screenshot)

image

@ZLoth ZLoth added the enhancement New feature or request label Sep 11, 2024
@advplyr
Copy link
Owner

advplyr commented Sep 11, 2024

There is actually a button to reset the changes so you don't have to refresh the page.

image

Keeping the removed chapters there would complicate the UI since we are iterating through the chapters and validating. We would have to store removed chapters and their index in another array then merge them just for display purposes.

I don't see the effort involved in doing that being worth it. I also prefer not to see the chapter there once I remove it and before I hit save.

The chapter editor will eventually be refactored. There is a lot of changes I want to do and a lot of changes that have been suggested.

@advplyr advplyr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
@ZLoth
Copy link
Author

ZLoth commented Sep 11, 2024

I understand. Being able to import chapters from metatag information is more important to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants