feat: Add support for "Open Current Chapter" button #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichwall
reviewed
Aug 25, 2024
| @@ -48,6 +48,7 @@ | |||
| "ButtonNextChapter": "Next Chapter", | |||
| "ButtonNextItemInQueue": "Next Item in Queue", | |||
| "ButtonOk": "Ok", | |||
| "ButtonOpenCurrentChapter": "Open Current Chapter", | |||
There was a problem hiding this comment.
We only want to add the string to the English file, not all of the other files unless you know the translation (Weblate will handle the other languages)
There was a problem hiding this comment.
How do i undo all the changes? do i just undo locally and commit again?
There was a problem hiding this comment.
If you did all of the changes in one commit you can do git revert [SHA], or checkout the files from a specific commit and then do another commit, or undo it manually.
Thanks for doing that, it makes it easier to review the changes. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a button to the playerUI if there is an ebook that goes along with the audiobook. If the file is not an epub it will just open like normal but if it is an epub the file will open to the current chapter of the audiobook that is being played.