-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nuxt-bridge ft nitro #3450
Open
wommy
wants to merge
3
commits into
advplyr:master
Choose a base branch
from
wommy:nuxtBridge-n-nitro
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
nuxt-bridge ft nitro #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+27
to
+31
var uuid = "xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx".replace(/[xy]/g, function(c) { | ||
var r = (d + Math.random()*16)%16 | 0; | ||
d = Math.floor(d/16); | ||
return (c=="x" ? r : (r&0x7|0x8)).toString(16); | ||
}); |
Check failure
Code scanning / CodeQL
Insecure randomness High
This uses a cryptographically insecure random number generated at in a security context.
Math.random()
Error loading related location
Loading There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is in the carried over code; not mine
i could PR this too
discussion here |
wommy
force-pushed
the
nuxtBridge-n-nitro
branch
from
October 7, 2024 14:54
87d105f
to
c840d37
Compare
issue w/ hookable, defu version mismatch |
Closed
wommy
force-pushed
the
nuxtBridge-n-nitro
branch
from
October 17, 2024 01:25
c840d37
to
b54882b
Compare
wommy
force-pushed
the
nuxtBridge-n-nitro
branch
from
October 17, 2024 02:09
b54882b
to
e77609e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.