Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Template #3603

Merged
merged 2 commits into from
Nov 19, 2024
Merged

PR Template #3603

merged 2 commits into from
Nov 19, 2024

Conversation

nichwall
Copy link
Contributor

Brief summary

This PR adds a PR template to the repository for new PRs. There is not an associated issue.

In-depth Description

This PR sets up the text input for PRs using the template to improve the quality and standardize the format of PRs. Unlike the issue templates which are able to have distinct text boxes and dropdowns, the PR template support on GitHub only seems to allow for a single PR template that is pasted into the text box.

How have you tested this?

Experimentation in a test repo.

Screenshots

image

@mikiher
Copy link
Contributor

mikiher commented Nov 12, 2024

This looks good as a first step. A couple of suggestions:

  • Add somthing about passing all checks
  • Add an optional Fixes # section

@advplyr
Copy link
Owner

advplyr commented Nov 12, 2024

For users who haven't had a PR approved yet the checks won't run until they are manually approved

@nichwall
Copy link
Contributor Author

Thanks for the feedback. I can add a blurb about passing checks and that they won't run until approved. I think the checks can run in forks though, so they could still check that the checks pass in their fork to reduce the chance of needing to change something after it's reviewed.

@advplyr
Copy link
Owner

advplyr commented Nov 19, 2024

Thanks!

@advplyr advplyr merged commit ea3a6fd into advplyr:master Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants