Remove unnecessary episode_download_queue_updated socket event causing OOM #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3601.
The first commit removes an unnecessary socket event with a large payload that was emitted every time an episode download was queued. If a large number of episodes
nwere queued, this caused the creation ofO(n^2)large objects to be created in quick sucession and queued for sending through the web socket, which caused an OOM for n=~2000.The second commit resolves an unrelated bug in the podcast item page, in which if you pressed on the button to clear the download queue for a library item, the button and the message
{0} Episode(s) queued for downloadwere not removed after the download queue was emptied.