Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock image building actually builds a image #102

Open
dajohnso opened this issue Jan 25, 2013 · 2 comments
Open

mock image building actually builds a image #102

dajohnso opened this issue Jan 25, 2013 · 2 comments

Comments

@dajohnso
Copy link

I noticed that the behaviour for mock image building has changed now with tim present. Pre-tim, a mock image build was practically a no-op however now with tim in place, the template actually builds a image when I request a mock build.

sloranz mentioned there are two type of mock builds for imagefactory and in order to get a fake build (like we did pre-tim), we would need to edit the templates os name (to FedoraMock or RHELMock) which I assume we would want to do on the fly as we pass the user's template to imagefactory.

@mtaylor
Copy link

mtaylor commented Feb 6, 2013

Hey, could you elaborate a little bit on this issue, I'm not entirely sure what you are requesting here. Thanks.

@dajohnso
Copy link
Author

Basically I am thinking we want mock builds to continue being a no op (like pre-tim conductor behaviour). In order for that to happen, the template os name needs to use FedoraMock or RHELMock. When originally discovering this and discussing with Dev, the line of thought was have tim update the os template name on the fly when mock target is requested otherwise mock builds actually build a full blown image which mock does not need or use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants