You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When an image is imported, it looks like the ProviderImage and TargetImage both have their status set to "IMPORTED". But right now, calling imported? launches a chain of queries that ultimately checks whether BaseImage is imported or not, even though those methods could check if status == 'IMPORTED' and avoid the lookup.
I was going to send a quick pull request for this, but there's this wrinkle:
after_create :create_import, :if => :imported?
The text was updated successfully, but these errors were encountered:
(This, of course, is a minor RFE, versus any sort of serious problem. But it can save a couple database queries where its parents aren't already in cache.)
IIRC the TargetImage gets it's status from the BaseImage so we'll at least need to keep this for TargetImage. But ProviderImage should look up the TargetImage status rather than having to do a load of joins to get the BaseImage.
When an image is imported, it looks like the ProviderImage and TargetImage both have their status set to "IMPORTED". But right now, calling
imported?
launches a chain of queries that ultimately checks whether BaseImage is imported or not, even though those methods could check ifstatus == 'IMPORTED'
and avoid the lookup.I was going to send a quick pull request for this, but there's this wrinkle:
The text was updated successfully, but these errors were encountered: