-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] ClaSP: Adds parallelization for distance computations and numbarize function calls #1692
Conversation
Thank you for contributing to
|
maybe convert to a BaseSeriesTransformer at the same time (#1618)? |
I was thinking about removing the Transformer all together and merge it into ClaSP Segmenter? :) Or should I convert it? |
I meant merge the Transformer with the Segmenter, and remove the Transformer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can either convert it or merge into the segmenter. Up to you really, if you think the transform has potential for usage elsewhere may be nice to keep.
I think remove the transformer and just merge it into a clasp segmenter is best way forward |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you @MatthewMiddlehurst and @TonyBagnall I set n_jobs to 1 and have converted the BaseTransformer to a BaseSeriesTransformer for now. Felt like merging everything into one module is also not the best option for now. Might re-consider this in the future :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is mostly a performance enhancement of the ClaSP implementation by: