Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Tidy, deprecation actions and testing for sklearn estimators #1701

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Jun 18, 2024

What does this implement/fix? Explain your changes.

  • Adds ClassifierMixin and RegressorMixin to sklearn estimators
  • Carries out some deprecation actions for the classifier
  • Adds sklearn testing for regressor rotf
  • Makes some changes to data processing to accommodate for the above

@aeon-actions-bot aeon-actions-bot bot added classification Classification package enhancement New feature, improvement request or other non-bug code enhancement regression Regression package labels Jun 18, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#7E0206}{\textsf{regression}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)

@MatthewMiddlehurst MatthewMiddlehurst changed the title [ENH] Tidy, deprecation actions and testing for Rotation Forest estimators [ENH] Tidy, deprecation actions and testing for sklearn estimators Jun 19, 2024
@TonyBagnall
Copy link
Contributor

TonyBagnall commented Jun 19, 2024

if not already there, could you add the deprecation actions to this list and tag it? Sorry, I like lists :)

#1393

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MatthewMiddlehurst MatthewMiddlehurst merged commit e9b7b42 into main Jun 24, 2024
14 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/rotf-and-fp branch June 24, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement regression Regression package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants