-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Write developer documentation for type hints including soft dependencies. #1857
Comments
@aeon-actions-bot assign @vedpawar2254 |
Added a documentation file on adding type hints that fixes aeon-toolkit#1857
PR #2424 does not describe handling of soft-dependencies sufficiently.
The example in the current documentation page does not include the usage of any conditionally-imported types. The displayed function is a input validation function and not related to the type-checking. |
ok @SebastianSchmidl ill fix it |
Ah yep, did not mean to close this, sorry. |
Describe the issue linked to the documentation
Developer documentation does not sufficiently include guidance for adding type hints, espceically in situations where soft dependencies are required.
Suggest a potential alternative/fix
Add a new page in
docs/developer_guide/
on adding type hints.PyODAdapter
is a good example of type hints with soft dependencies, following PEP 563.The text was updated successfully, but these errors were encountered: