Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Rethink the mask parameter in similarity search #2020

Open
baraline opened this issue Sep 1, 2024 · 5 comments
Open

[ENH] Rethink the mask parameter in similarity search #2020

baraline opened this issue Sep 1, 2024 · 5 comments
Labels
enhancement New feature, improvement request or other non-bug code enhancement similarity search Similarity search package

Comments

@baraline
Copy link
Member

baraline commented Sep 1, 2024

Describe the issue

Currently, a boolean mask is created to indicate which part of the input time series dataset is to be ignored from the computations if the query used in the search is included in the input time series dataset.

The issue is that the computations linked to these areas are still made, they are only removed from the result array before returning it.

Suggest a potential alternative/fix

Rethink the mask parameter to be able to skip computation that won't be used instead of ignoring them later on.

Additional context

No response

@baraline baraline added enhancement New feature, improvement request or other non-bug code enhancement similarity search Similarity search package labels Sep 1, 2024
@vedpawar2254
Copy link
Contributor

@aeon-actions-bot assign @vedpawar2254

@MatthewMiddlehurst
Copy link
Member

@vedpawar2254 please don't take on multiple issues at once unless the others are close to completion.

@vedpawar2254
Copy link
Contributor

Hi, @MatthewMiddlehurst I completed the work and sebastian has reviewed it, I'll update the PR tonight

@MatthewMiddlehurst
Copy link
Member

@vedpawar2254 you assigned #2081

@vedpawar2254
Copy link
Contributor

vedpawar2254 commented Dec 12, 2024

Yes @MatthewMiddlehurst , I am working on that rn but it's kind of getting the better of so I though I'll try something different so I can start on that one again with a fresh mind, i'll unassign myself if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement similarity search Similarity search package
Projects
None yet
Development

No branches or pull requests

3 participants