Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RDSTRegressor expected results on covid3month #2290

Open
baraline opened this issue Nov 1, 2024 · 2 comments
Open

[BUG] RDSTRegressor expected results on covid3month #2290

baraline opened this issue Nov 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@baraline
Copy link
Member

baraline commented Nov 1, 2024

Describe the bug

The results produced locally do not match those produced in the CI for RDSTRegressor on Covid3Month.

The expected results seem to be fine for the other dataset and for RDSTClassifier.

Steps/Code to reproduce the bug

from aeon.testing.expected_results.results_reproduction.regressor_results_reproduction import _print_results_for_regressor
_print_results_for_regressor("RDSTRegressor", "Covid3Month")

Outputs :

RDSTRegressor - Covid3Month
[
0.0687,
0.071,
0.0227,
0.0425,
0.0834,
0.0251,
0.0064,
0.1398,
0.0667,
0.031,
]

Expected results

The test do not fail and results produced locally match those produce in the CI

Actual results

FAILED aeon/testing/tests/test_all_estimators.py::test_all_estimators[check_regressor_against_expected_results(estimator_class=RDSTRegressor)] - AssertionError: 
Arrays are not almost equal to 2 decimals
Failed to reproduce results for RDSTRegressor on Covid3Month
Mismatched elements: 6 / 10 (60%)
Max absolute difference: 0.10256623
Max relative difference: 4.7437444
 x: array([0.04, 0.04, 0.04, 0.04, 0.04, 0.04, 0.04, 0.04, 0.04, 0.04])
 y: array([0.07, 0.07, 0.02, 0.04, 0.08, 0.03, 0.01, 0.14, 0.07, 0.03])

Versions

System:
python: 3.10.13 | packaged by Anaconda, Inc. | (main, Sep 11 2023, 13:24:38) [MSC v.1916 64 bit (AMD64)]
executable: C:\Users\antoine\anaconda3\envs\aeon_dev\python.exe
machine: Windows-10-10.0.22631-SP0
Python dependencies:
aeon: 0.11.1
pip: 23.3.1
setuptools: 68.0.0
scikit-learn: 1.2.2
numpy: 1.24.4
numba: 0.58.1
scipy: 1.11.4
pandas: 2.0.3

@TonyBagnall
Copy link
Contributor

@baraline was this fixed by #2176 ?

@baraline
Copy link
Member Author

Hey this is the remaining bug after the PR, so no. Can you reproduce it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants