Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Refactor BinSegSegmenter to BinSegmenter #2408

Merged
merged 8 commits into from
Nov 28, 2024
Merged

[ENH] Refactor BinSegSegmenter to BinSegmenter #2408

merged 8 commits into from
Nov 28, 2024

Conversation

TonyBagnall
Copy link
Contributor

BinSeg is short for BinSegmenter, so the name makes no sense

@TonyBagnall TonyBagnall added the transformations Transformations package label Nov 27, 2024
@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Nov 27, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Nov 27, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#0e8a16}{\textsf{segmentation}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@TonyBagnall TonyBagnall added the full pytest actions Run the full pytest suite on a PR label Nov 28, 2024
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renaming makes sense and all occurrences seem to have been dealt with

@aeon-actions-bot aeon-actions-bot bot removed the full pytest actions Run the full pytest suite on a PR label Nov 28, 2024
@aeon-actions-bot aeon-actions-bot bot added the full pytest actions Run the full pytest suite on a PR label Nov 28, 2024
@TonyBagnall TonyBagnall merged commit d3647a1 into main Nov 28, 2024
19 checks passed
@TonyBagnall TonyBagnall deleted the ajb/binseg branch November 28, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement full pytest actions Run the full pytest suite on a PR transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants