Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branding pack #34

Open
aeon1234 opened this issue Jul 16, 2018 · 10 comments
Open

branding pack #34

aeon1234 opened this issue Jul 16, 2018 · 10 comments

Comments

@aeon1234
Copy link
Contributor

the reddit sidebar includes a link to a branding pack which is hosted on dropbox.
I don't know who uploaded it there but I think it should be reuploaded to this github and also linked to github instead of dropbox.
it could also included in the download section of the website.

@stoffu
Copy link
Contributor

stoffu commented Jul 16, 2018

I agree. You’re very welcome to submit a pull request on this.

@aeon1234
Copy link
Contributor Author

okay. will do it in the next 30h.

but 2 questions:

  • where should I upload the files? new dir? which name?
  • should I zip them or upload them separately?

@stoffu
Copy link
Contributor

stoffu commented Jul 16, 2018

This repository itself is the website’s file structure. You need to follow the typical open source contribution procedure:

  1. Fork this repository to have your own repository

  2. Clone your repository to your computer

  3. Make changes to your local repository and push commits to your own repository

  4. Click the “create pull request” button on the GitHub web interface

There are plenty of tutorials online.

@aeon1234
Copy link
Contributor Author

aeon1234 commented Jul 17, 2018

it seems you misunderstood me. english is not my first language and I sometimes have issues to express me in foreign languages. sorry.

This repository itself is the website’s file structure.

yes, I understand.

  • but where should I upload the branding files in this file structure?
  • should I create a new directory and if so what is a good name for this directory (e.g. branding)?
  • should I compress all files as zip and upload the zip file or should I upload all files separately (e.g. AEON_logo_16x16.png AEON_logo_25x25.png AEON_logo_32x32.png ...)?

I hope my questions are more clear now. thank you for your patience.

@stoffu
Copy link
Contributor

stoffu commented Jul 17, 2018

Ah, I misunderstood your question, sorry. I'm not really familiar with either the website repository nor the branding pack, so please follow your own reasoning and propose something as a PR. Hopefully there'll be someone knowledgable who can make some feedback.

@aeon1234
Copy link
Contributor Author

aeon1234 commented Sep 6, 2018

maybe it would make sense if someone more trustworthy (stoffu / smooth ?) could zip the branding files together and pull it. so we could change the dropbox link on reddit sidebar and also additionally link it as one item on the website.

@stoffu
Copy link
Contributor

stoffu commented Sep 7, 2018

I don't think much trust in involved when it comes to general downloadable materials that are not binary executables. You can create a zip package and submit a PR as usual, which will be reviewed and verified by anyone such as myself.

@aeon1234
Copy link
Contributor Author

I'm happy with current state, so I'm fine if this issue gets closed.

@BigslimVdub
Copy link
Contributor

aeon_title1_1360x512

Thoughts? It goes in line with #52 Feel free to edit your branding pack to reflect this type of change if you agree. I did not match colors exactly to branding pack colors but you get the idea.

@aeon1234
Copy link
Contributor Author

I did not create the images in the branding pack. I also have not much experience in editing images.

and I like the idea. I hope others will also give feedback about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants