Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOFOImportance accepts groups params for GroupKFold cv #57

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

kingychiu
Copy link
Contributor

The groups param is passing to sklearn.model_selection.cross_validate directly

@aerdem4
Copy link
Owner

aerdem4 commented Jan 13, 2024

Sorry for my very late response. Would you consider renaming groups to something like cv_groups? Because groups is clear when function is named cross validate but not that clear for LOFO class.

@kingychiu
Copy link
Contributor Author

Hi @aerdem4, updated the name. The goal of this change is really want to have groupkfold here.

@aerdem4 aerdem4 merged commit 67d787a into aerdem4:master Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants