Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Circuits and Benches #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Optimize Circuits and Benches #7

wants to merge 7 commits into from

Conversation

0xVikasRushi
Copy link

@0xVikasRushi 0xVikasRushi commented Sep 16, 2024 •
edited
Loading

Changes

  • optimized state_transition_circuit
  • updated benches circuit according new witness values
Bench Name Benchmark Time Max Memory Usage
wrapper_circuit 121.36 sec 20.46 GB
state_transition 1.01 sec 0.46 GB
voter_benches 301.04 ms 0.26 GB
voter_test 301.27 ms 0.26 GB

entire memory usage was calculated by the crate sysinfo

max ram usage

0xVikasRushi
0xVikasRushi commented Sep 16, 2024
View reviewed changes
aggregator/src/state_transition.rs Outdated
for enc_vote in incoming_vote {
public_inputs.extend(enc_vote.limbs());
}
// insert_leaf::<F, 3, 2>(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vishalkulkarni45. it should be un-commented out right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vishalkulkarni45 Vishalkulkarni45 Vishalkulkarni45 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xVikasRushi @Vishalkulkarni45 @rahulghangas