Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Simplify Datastore flow #969

Open
kingsleyzissou opened this issue Nov 30, 2020 · 4 comments
Open

Simplify Datastore flow #969

kingsleyzissou opened this issue Nov 30, 2020 · 4 comments
Milestone

Comments

@kingsleyzissou
Copy link
Contributor

Bug Report

things could be even simplified
every time you do subscription
simply refetch changes from the database
it will be slower
but it will functionally work
and make things very very simple
so entire hooks issues will go away
ID Swap logic will go away
and any update will simply update store again and send generic hook to "refetch all"

@kingsleyzissou kingsleyzissou added this to the Demo MVP milestone Nov 30, 2020
@kingsleyzissou
Copy link
Contributor Author

cc @wtrocki from our conversation

@RinkiyaKeDad
Copy link
Contributor

Hi @kingsleyzissou! Can I work on this issue? Could you please provide some more detials about what needs to be done? Thanks.

@kingsleyzissou
Copy link
Contributor Author

Hey @RinkiyaKeDad, I should have had myself assigned to this because it is something I'm coming back to now. Basically we had a PR up for this issue, but we decided to go back to the drawing board and simplify our approach. I can go through some of the issues and see if there is one that I could see if we need help on. The thing is quite a lot depends on this issue here.

@RinkiyaKeDad
Copy link
Contributor

Thanks, @kingsleyzissou! It'd be great if you could point me towards an issue to start with. I was going through the list of issues but wasn't able to figure out which one would be a good starting point 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants