Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safari 16 to images #576

Open
Rendez opened this issue Sep 27, 2022 · 8 comments
Open

Add Safari 16 to images #576

Rendez opened this issue Sep 27, 2022 · 8 comments

Comments

@Rendez
Copy link

Rendez commented Sep 27, 2022

The PR for Safari 15 is here, but 16 is so far missing. Can someone with more knowledge open a PR for this change?

Thanks community!

@vania-pooh
Copy link
Member

@Rendez what is exact WebKit version you consider corresponding to Safari 16?

@Rendez
Copy link
Author

Rendez commented Sep 27, 2022

That is the golden question, I am trying to figure it out, but it isn't specified yet: https://en.wikipedia.org/wiki/Safari_version_history#cite_note-117

@Rendez
Copy link
Author

Rendez commented Sep 27, 2022

Ok, so I found a resource: https://tauri.app/v1/references/webview-versions/#webkit-versions-in-safari, and I double-checked this along my Safari.app -> XPCServices/com.apple.WebKit.WebContent.Safari.xpc/Contents/version.plist

<key>CFBundleVersion</key>
<string>17614.1.25.9.10</string>

Note the 614.1.25.9.10 which seems to be the webkit version, which also is greater than Safari 15 by a couple of major versions, just like it happens between jumps in Safari versions according to that Wikipedia article.

My Safari on the latest Monterey (12.6) at the time of this comment is Version 16.0 (17614.1.25.9.10, 17614)

@Rendez
Copy link
Author

Rendez commented Sep 27, 2022

For building the docker image I see the build-arg $WEBKIT_TAG, but I'm not sure which branch from the webkit repo to pick, e.g.: https://github.com/WebKit/WebKit/tree/safari-7614.1.21-branch

@Rendez
Copy link
Author

Rendez commented Oct 7, 2022

@vania-pooh does this require something else than modifying the .adoc?

@vania-pooh
Copy link
Member

vania-pooh commented Oct 7, 2022

@Rendez this requires building respective image. :)

@Rendez
Copy link
Author

Rendez commented Nov 4, 2022

I tried creating the docker image so far without luck, any hints?

@vania-pooh
Copy link
Member

@Rendez we are investigating this stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants