Fixed syntax errors

aerospike · Feb 8, 2024 · 806c36d · 806c36d
1 parent 6f643af
commit 806c36d
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 10 deletions.
diff --git a/.github/workflows/build-bindings.yml b/.github/workflows/build-bindings.yml
@@ -529,3 +529,37 @@ jobs:
         mkdir -p testDir lib/binding/openssl@3/ lib/binding/openssl@1/
         cd testDir
         bun install ..
+
+  test-typescript-install:
+    runs-on: ubuntu-latest
+    needs: [manylinux, macOS-x86]
+    steps:
+    - uses: actions/checkout@v2
+      with:
+        submodules: recursive
+
+    - uses: ./.github/workflows/combine-bindings/
+
+    - uses: actions/setup-node@v4
+      with:
+        node-version: ${{ env.LOWEST_SUPPORTED_NODEJS_VERSION }}
+        architecture: 'x64'
+
+    - name: Modify the package.json
+      run: |
+        mkdir my-aerospike-project
+        cd my-aerospike-project
+        npm init -y
+        npm install typescript ts-node --save-dev
+        npm install aerospike
+        cp ../examples/typescript.ts
+        npx tsc index.ts
+        node index.js
+
+    - name: Run tests
+      run: |
+        mkdir -p testDir lib/binding/openssl@3/ lib/binding/openssl@1/
+        cd testDir
+        bun install ..
+
+
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -397,18 +397,17 @@ jobs:
         node-version: ${{ matrix.node-version }}
         architecture: 'x64'
 
-   - uses: actions/download-artifact@v4
+    - uses: actions/download-artifact@v4
       with:
         name: binding-${{ matrix.node-version }}
 
     - name: make binding folder
       run: mkdir lib/binding
 
     - name: Install client
-      #fix the convention here
       run: |
         cp -r node-v115-linux-x64 lib/binding/node-v115-linux-x64
-        
+
     - name: Modify the package.json
       run: |
         mkdir my-aerospike-project
@@ -418,10 +417,4 @@ jobs:
         npm install ..
         cp ../examples/typescript.ts
         npx tsc index.ts
-        node index.js
-
-    - name: Run tests
-      run: |
-        mkdir -p testDir lib/binding/openssl@3/ lib/binding/openssl@1/
-        cd testDir
-        bun install ..
+        node index.js