From 806c36d8c7b51eb96f1963e8fd017f04b94b1031 Mon Sep 17 00:00:00 2001 From: Dominic Pelini <111786059+DomPeliniAerospike@users.noreply.github.com> Date: Thu, 8 Feb 2024 10:32:53 -0700 Subject: [PATCH] Fixed syntax errors --- .github/workflows/build-bindings.yml | 34 ++++++++++++++++++++++++++++ .github/workflows/tests.yml | 13 +++-------- 2 files changed, 37 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build-bindings.yml b/.github/workflows/build-bindings.yml index cc0fc503..a3c22a30 100644 --- a/.github/workflows/build-bindings.yml +++ b/.github/workflows/build-bindings.yml @@ -529,3 +529,37 @@ jobs: mkdir -p testDir lib/binding/openssl@3/ lib/binding/openssl@1/ cd testDir bun install .. + + test-typescript-install: + runs-on: ubuntu-latest + needs: [manylinux, macOS-x86] + steps: + - uses: actions/checkout@v2 + with: + submodules: recursive + + - uses: ./.github/workflows/combine-bindings/ + + - uses: actions/setup-node@v4 + with: + node-version: ${{ env.LOWEST_SUPPORTED_NODEJS_VERSION }} + architecture: 'x64' + + - name: Modify the package.json + run: | + mkdir my-aerospike-project + cd my-aerospike-project + npm init -y + npm install typescript ts-node --save-dev + npm install aerospike + cp ../examples/typescript.ts + npx tsc index.ts + node index.js + + - name: Run tests + run: | + mkdir -p testDir lib/binding/openssl@3/ lib/binding/openssl@1/ + cd testDir + bun install .. + + diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3dad9484..f1028256 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -397,7 +397,7 @@ jobs: node-version: ${{ matrix.node-version }} architecture: 'x64' - - uses: actions/download-artifact@v4 + - uses: actions/download-artifact@v4 with: name: binding-${{ matrix.node-version }} @@ -405,10 +405,9 @@ jobs: run: mkdir lib/binding - name: Install client - #fix the convention here run: | cp -r node-v115-linux-x64 lib/binding/node-v115-linux-x64 - + - name: Modify the package.json run: | mkdir my-aerospike-project @@ -418,10 +417,4 @@ jobs: npm install .. cp ../examples/typescript.ts npx tsc index.ts - node index.js - - - name: Run tests - run: | - mkdir -p testDir lib/binding/openssl@3/ lib/binding/openssl@1/ - cd testDir - bun install .. \ No newline at end of file + node index.js \ No newline at end of file