addressing comments

aerospike · Mar 4, 2024 · 181c1c6 · 181c1c6
1 parent 2884e45
commit 181c1c6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/api/v1/zz_generated.deepcopy.go b/api/v1/zz_generated.deepcopy.go
diff --git a/controllers/rack.go b/controllers/rack.go
@@ -13,6 +13,7 @@ import (
 	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/util/intstr"
 	"k8s.io/apimachinery/pkg/util/sets"
+	"k8s.io/utils/ptr"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
 	asdbv1 "github.com/aerospike/aerospike-kubernetes-operator/api/v1"
@@ -559,7 +560,8 @@ func (r *SingleClusterReconciler) reconcileRack(
 
 	// Safe check to delete all dangling pod services which are no longer required
 	// There won't be any case of dangling pod service with MultiPodPerHost false, so ignore that case
-	if !podServiceNeeded(r.aeroCluster.Spec.PodSpec.MultiPodPerHost, &r.aeroCluster.Spec.AerospikeNetworkPolicy) {
+	if ptr.Deref(r.aeroCluster.Spec.PodSpec.MultiPodPerHost, false) &&
+		!podServiceNeeded(r.aeroCluster.Spec.PodSpec.MultiPodPerHost, &r.aeroCluster.Spec.AerospikeNetworkPolicy) {
 		if err := r.cleanupDanglingPodServices(rackState); err != nil {
 			return reconcileError(err)
 		}