nit-pick

aerospike · Nov 3, 2023 · e67eea1 · e67eea1
1 parent 12962e4
commit e67eea1
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -79,12 +79,6 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - persistentvolumes
-  verbs:
-  - get
 - apiGroups:
   - ""
   resources:

diff --git a/controllers/aerospikecluster_controller.go b/controllers/aerospikecluster_controller.go
@@ -113,7 +113,6 @@ type RackState struct {
 // +kubebuilder:rbac:groups=core,resources=pods/exec,verbs=create
 // +kubebuilder:rbac:groups=core,resources=services,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=persistentvolumeclaims,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=core,resources=persistentvolumes,verbs=get
 // +kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=configmaps,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=secrets,verbs=get

diff --git a/controllers/statefulset.go b/controllers/statefulset.go
@@ -1468,7 +1468,7 @@ func getSTSContainerPort(
 	portNames := make([]string, 0, len(defaultContainerPorts))
 
 	// Sorting defaultContainerPorts to fetch map in ordered manner.
-	// Helps in comparing STS before updating.
+	// Helps reduce unnecessary sts object updates.
 	for portName := range defaultContainerPorts {
 		portNames = append(portNames, portName)
 	}