Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OM128 - namespace view - 7.0 changes initial commit #77

Merged
merged 10 commits into from
Nov 7, 2023
Merged

Conversation

mphanias
Copy link
Contributor

initial checkin with all 7.0 changes
7.0 based theme to combine 6.0 and 7.0 changes while showing state, topk and time-series values

initial checkin with all 7.0 changes
7.0 based theme to combine 6.0 and 7.0 changes while showing state, topk and time-series values
@mphanias mphanias requested review from sunilvirus and hev October 23, 2023 07:04
Copy link
Collaborator

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my comments on #76 we should have alerts for Critical, Error, and Warning seperate and color coded to match alerts view.

changed layout, alerts display type
1. arranged panel
2. modified timeseries legend as last,min,max and mean
3. corrected panel titles as rate where applicable
4. fixed alerts url issue
5. fixed alerts panel critical color
fixed code to remove input and elements section
will handle docker provisioning configs as another jira ticket
1. corrected index used panel title
2. updated labels for 6x queries / panels
3. corrected panel label in resources row
4. replaced 1m with rate-interval everywhere
fixed alerts url bug, unnecessary param is removed.
@mphanias
Copy link
Contributor Author

mphanias commented Nov 1, 2023

  1. updated alerts panel as pie chart with sum of all alerts and representing appropriate colour
  2. updated descriptions

updated descriptions
fixed query type as instant for set-quota to show topk values
@mphanias mphanias requested a review from hev November 1, 2023 04:56
corrected alert query condition to filter only for selected namespace
updated descriptions in data, inded and memory panels
Copy link
Collaborator

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pie chart works. Approved.

@sunilvirus sunilvirus merged commit 43845f5 into dev Nov 7, 2023
1 check passed
@sunilvirus sunilvirus deleted the OM128 branch November 7, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants