Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OM129 - unique data usgae initial commit #78

Merged
merged 4 commits into from
Nov 7, 2023
Merged

OM129 - unique data usgae initial commit #78

merged 4 commits into from
Nov 7, 2023

Conversation

mphanias
Copy link
Contributor

modified queries according to the 7.0 stat and metrics added all-cluster master-object and unique-usage-bytes view which are all connected to a prometheus instance

modified queries according to the 7.0 stat and metrics
added all-cluster master-object and unique-usage-bytes view which are all connected to a prometheus instance
@mphanias mphanias requested review from sunilvirus and hev October 23, 2023 07:26
Copy link
Collaborator

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should include the all option for the cluster_name variable.

added historical view for all-cluster rows,
updated panel title to standard total
updated color for all-cluster panels
modified queries not-to-use node variable in queries
modified all-cluster history timeseries to show data for each cluster
@hev hev self-requested a review October 31, 2023 20:48
Copy link
Collaborator

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should allow you to select All, but this approach works too. Approved.

@sunilvirus sunilvirus merged commit d5f41a6 into dev Nov 7, 2023
1 check passed
@sunilvirus sunilvirus deleted the OM129 branch November 7, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants