-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for pki auth #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about having validations in conjunction with TLS configurations when PKI auth mode is used. I'll let @mphanias chip in.
observer.go
Outdated
if authMode == "external" { | ||
clientPolicy.AuthMode = aero.AuthModeExternal | ||
} else if authMode == "pki" { | ||
clientPolicy.AuthMode = aero.AuthModePKI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if authMode == "external" { | |
clientPolicy.AuthMode = aero.AuthModeExternal | |
} else if authMode == "pki" { | |
clientPolicy.AuthMode = aero.AuthModePKI | |
switch authMode { | |
case "internal": | |
clientPolicy.AuthMode = aero.AuthModeInternal | |
case "external": | |
clientPolicy.AuthMode = aero.AuthModeExternal | |
case "pki": | |
clientPolicy.AuthMode = aero.AuthModePKI | |
default: | |
log.Fatalln("Invalid auth mode: only `internal`, `external`, `pki` values are accepted.") | |
} |
and remove line 85-86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. I also added the default value of "" as an option.
Thanks @realmgic . Two things,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM. I'll let @mphanias take a look.
No description provided.