Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEC-430 configure test and linting for all helm charts #48

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

davi17g
Copy link
Collaborator

@davi17g davi17g commented Nov 20, 2024

No description provided.

@davi17g davi17g requested a review from arrowplum November 20, 2024 18:54
Copy link
Contributor

@arrowplum arrowplum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works but what about the other charts?, is ako needed for what is there right now?, and do we need those uncommented lines in the values?

#
storage:
seeds:
- aerocluster-0-0.aerocluster.aerospike.svc.cluster.local:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose (uncommented blocks?)

- /mnt/disks/avs-meta/avs-meta.dat
EOF

- name: Run chart-testing (install)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am reading this right, it checks if any chart has changed and if so runs lint on vector.

Is this generic? What does test do in this case? Do we need to install ako etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants