From f2ce3c7cb8228c41b3348458809372f0b1d3fe68 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 16:01:28 +0200 Subject: [PATCH 01/17] Create lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 44 +++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 .github/workflows/lint-and-test-charts.yaml diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml new file mode 100644 index 0000000..f59c1ea --- /dev/null +++ b/.github/workflows/lint-and-test-charts.yaml @@ -0,0 +1,44 @@ +name: Lint and Test Charts + +#on: pull_request +on: + push: + branches: + - "VEC-430-configure-test-and-linting-for-all-helm-charts" +jobs: + lint-test: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + with: + fetch-depth: 0 + + - name: Set up Helm + uses: azure/setup-helm@v4.2.0 + with: + version: v3.14.4 + + - uses: actions/setup-python@v5 + with: + python-version: '3.x' + check-latest: true + + - name: Set up chart-testing + uses: helm/chart-testing-action@v2.7.0 + + - name: Output default branch + run: | + echo "Branch: ${{ github.event.repository.default_branch }}" + +# - name: Run chart-testing (lint) +# if: steps.list-changed.outputs.changed == 'true' +# run: ct lint --target-branch ${{ github.event.repository.default_branch }} +# +# - name: Create kind cluster +# if: steps.list-changed.outputs.changed == 'true' +# uses: helm/kind-action@v1.10.0 +# +# - name: Run chart-testing (install) +# if: steps.list-changed.outputs.changed == 'true' +# run: ct install --target-branch ${{ github.event.repository.default_branch }} \ No newline at end of file From c12524d0ef8d0fee92537cce772d9e1a3c215fb4 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 16:02:34 +0200 Subject: [PATCH 02/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index f59c1ea..65e572f 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -25,7 +25,7 @@ jobs: check-latest: true - name: Set up chart-testing - uses: helm/chart-testing-action@v2.7.0 + uses: helm/chart-testing-action@v2.6.1 - name: Output default branch run: | From e90c98d5f63764a6c9d0469df46fcccf2b08dc4c Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 16:07:20 +0200 Subject: [PATCH 03/17] Update values.yaml --- aerospike-vector-search/values.yaml | 306 ++++++++++++++-------------- 1 file changed, 156 insertions(+), 150 deletions(-) diff --git a/aerospike-vector-search/values.yaml b/aerospike-vector-search/values.yaml index 6929792..8d2fa70 100644 --- a/aerospike-vector-search/values.yaml +++ b/aerospike-vector-search/values.yaml @@ -14,170 +14,176 @@ imagePullSecrets: [] nameOverride: "" fullnameOverride: "" -aerospikeVectorSearchConfig: {} -#cluster: -# # Unique identifier for this cluster. -# cluster-name: aerospike-vector-search +aerospikeVectorSearchConfig: + cluster: +# Unique identifier for this cluster. + cluster-name: aerospike-vector-search +# node-id: a1 # -# # Custom node-id as 8 byte long in Hexadecimal format. -# # It will be auto-generated if not specified. -# node-id: a1 +# If TLS is desired, TLS configuration ids used +# and associated TLS configurations. # -## If TLS is desired, TLS configuration ids used -## and associated TLS configurations. -#tls: -# service-tls: -# trust-store: -# store-file: tls/ca.aerospike.com.truststore.jks -# store-password-file: tls/storepass -# key-store: -# store-file: tls/avs.aerospike.com.keystore.jks -# store-password-file: tls/storepass -# key-password-file: tls/keypass +# tls: +# service-tls: +# trust-store: +# store-file: tls/ca.aerospike.com.truststore.jks +# store-password-file: tls/storepass +# key-store: +# store-file: tls/avs.aerospike.com.keystore.jks +# store-password-file: tls/storepass +# key-password-file: tls/keypass # -# interconnect-tls: -# trust-store: -# store-file: tls/ca.aerospike.com.truststore.jks -# store-password-file: tls/storepass -# key-store: -# store-file: tls/avs.aerospike.com.keystore.jks -# store-password-file: tls/storepass -# key-password-file: tls/keypass -# override-tls-hostname: avs.aerospike.com +# interconnect-tls: +# trust-store: +# store-file: tls/ca.aerospike.com.truststore.jks +# store-password-file: tls/storepass +# key-store: +# store-file: tls/avs.aerospike.com.keystore.jks +# store-password-file: tls/storepass +# key-password-file: tls/keypass +# override-tls-hostname: avs.aerospike.com # -# aerospike-tls: -# trust-store: -# store-file: tls/ca.aerospike.com.truststore.jks -# store-password-file: tls/storepass -# key-store: -# store-file: tls/avs.aerospike.com.keystore.jks -# store-password-file: tls/storepass -# key-password-file: tls/keypass -# override-tls-hostname: asd.aerospike.com +# aerospike-tls: +# trust-store: +# store-file: tls/ca.aerospike.com.truststore.jks +# store-password-file: tls/storepass +# key-store: +# store-file: tls/avs.aerospike.com.keystore.jks +# store-password-file: tls/storepass +# key-password-file: tls/keypass +# override-tls-hostname: asd.aerospike.com # -## The AVS service listening ports, TLS and network interface. -#service: -# ports: -# # Clear text service port. -# 5000: -# # Hostname/IP/network interface name to bind to. -# # If not specified binds to all interfaces. -# addresses: -# localhost -# # Required when running behind NAT -# advertised-listeners: -# default: -# # List of externally accessible addresses and -# # ports for this AVS instance. -# - address: 10.0.0.1 -# port: 5000 + feature-key-file: "/etc/aerospike-vector-search/secrets/features.conf" # -# # TLS service port. -# 5443: -# # Hostname/IP/network interface name to bind to. -# # If not specified binds to all interfaces. -# addresses: -# localhost -# tls-id: service-tls -# # Required when running behind NAT -# advertised-listeners: -# default: -# # List of externally accessible addresses and -# # ports for this AVS instance. -# # Use the hostname/domain name/IP here to match the TLS certificate. -# - address: 10.0.0.1 -# port: 5443 +# The AVS service listening ports, TLS and network interface. # -## Management API listening ports, TLS and network interface. -#manage: -# ports: -# # Clear text port -# 5040: -# # Hostname/IP/network interface name to bind to. -# # If not specified binds to all interfaces. -# addresses: -# localhost -# # Manage TLS port -# 5483: -# # Hostname/IP/network interface name to bind to. -# # If not specified binds to all interfaces. -# addresses: -# localhost -# tls-id: service-tls + service: + metadata-namespace: "avs-meta" +# Clear text service port. + ports: + 5000: +# Hostname/IP/network interface name to bind to. +# If not specified binds to all interfaces. + addresses: + "0.0.0.0" +# Required when running behind NAT +# advertised-listeners: +# default: +# List of externally accessible addresses and +# ports for this AVS instance. +# - address: 10.0.0.1 +# port: 5000 +# TLS service port. + 5443: +# Hostname/IP/network interface name to bind to. +# If not specified binds to all interfaces. +# addresses: +# localhost +# tls-id: service-tls +# Required when running behind NAT +# advertised-listeners: +# default: +# List of externally accessible addresses and +# ports for this AVS instance. +# Use the hostname/domain name/IP here to match the TLS certificate. +# - address: 10.0.0.1 +# port: 5443 # -## Intra cluster interconnect listening ports, TLS and network interface. -#interconnect: -# # Interconnect client side TLS configuration -# # when TLS is enabled for interconnect -# client-tls-id: interconnect-tls -# ports: -# # Clear text port -# 5001: -# # Hostname/IP/network interface name to bind to. -# # If not specified binds to all interfaces. -# addresses: -# localhost -# # TLS interconnect port -# 5444: -# #Hostname/IP/network interface name to bind to. -# # If not specified binds to all interfaces. -# addresses: -# localhost -# tls-id: interconnect-tls +# Management API listening ports, TLS and network interface. # -#heartbeat: -# # Seed nodes to discover and form a cluster. -# seeds: -# # Clear text seed -# - address: 192.168.1.5 -# port: 5001 -# # TLS seed node -# - address: 192.168.1.5 -# port: 5001 + manage: +# Clear text port + ports: + 5040: +# Hostname/IP/network interface name to bind to. +# If not specified binds to all interfaces. + addresses: + "0.0.0.0" +# Manage TLS port +# 5483: +# Hostname/IP/network interface name to bind to. +# If not specified binds to all interfaces. +# addresses: +# localhost +# tls-id: service-tls # -## To enable client authentication -#security: -# auth-token: -# private-key: samples/auth/private_key.pem -# public-key: samples/auth/public_key.pem -# token-expiry: 300_000 +# Intra cluster interconnect listening ports, TLS and network interface. # -## Aerospike DB storage configuration -#storage: -# seeds: -# - localhost: -# port: 3000 -# # Aerospike TLS port -# port: 3010 + interconnect: +# Interconnect client side TLS configuration +# when TLS is enabled for interconnect +# client-tls-id: interconnect-tls + ports: +# Clear text port + 5001: +# Hostname/IP/network interface name to bind to. +# If not specified binds to all interfaces. + addresses: + "0.0.0.0" +# TLS interconnect port +# 5444: +# Hostname/IP/network interface name to bind to. +# If not specified binds to all interfaces. +# addresses: +# localhost +# tls-id: interconnect-tls # -# client-policy: -# max-conns-per-node: 1000 -# # If TLS is required to connect to Aerospike -# tls-id: aerospike-tls -# # -# # Aerospike credentials if required. -# credentials: -# username: admin -# password-file: aerospike-password.txt +# heartbeat: # -## HNSW index configuration defaults -#hnsw: -# healer: -# # Schedule healer runs using Quartz cron expressions. -# # See https://www.freeformatter.com/cron-expression-generator-quartz.html -# # and https://www.quartz-scheduler.org/documentation/quartz-2.3.0/tutorials/crontrigger.html -# # Expression below runs the healer once every 5 hours. -# schedule: "0 0 0/5 ? * * *" -# # Disable vector integrity check. -# enable-vector-integrity-check: false +# Seed nodes to discover and form a cluster. # -## The logging properties. -#logging: -# file: /var/log/aerospike-vector-search/aerospike-vector-search.log -# enable-console-logging: true -# levels: -# root: debug - +# seeds: +# Clear text seed +# - address: 192.168.1.5 +# port: 5001 +# TLS seed node +# - address: 192.168.1.5 +# port: 5001 +# +# To enable client authentication +# +# security: +# auth-token: +# private-key: samples/auth/private_key.pem +# public-key: samples/auth/public_key.pem +# token-expiry: 300_000 +# +# Aerospike DB storage configuration +# + storage: + seeds: + - aerocluster-0-0.aerocluster.aerospike.svc.cluster.local: + port: 3000 +# Aerospike TLS port +# port: 3010 + client-policy: + max-conns-per-node: 1000 +# If TLS is required to connect to Aerospike +# tls-id: aerospike-tls +# Aerospike credentials if required. +# credentials: +# username: admin +# password-file: aerospike-password.txt +# +# HNSW index configuration defaults +# +# hnsw: +# healer: +# Schedule healer runs using Quartz cron expressions. +# See https://www.freeformatter.com/cron-expression-generator-quartz.html +# and https://www.quartz-scheduler.org/documentation/quartz-2.3.0/tutorials/crontrigger.html +# Expression below runs the healer once every 5 hours. +# schedule: "0 0 0/5 ? * * *" +# Disable vector integrity check. +# enable-vector-integrity-check: false +# +# The logging properties. +# + logging: +# file: /var/log/aerospike-vector-search/aerospike-vector-search.log + enable-console-logging: true +# levels: +# root: debug initContainers: [] From c54daa4e9b629a80ae0822ba4ee52da73da42562 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 16:36:53 +0200 Subject: [PATCH 04/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 33 +++++++++++++++++++-- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 65e572f..1e6e270 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -35,9 +35,36 @@ jobs: # if: steps.list-changed.outputs.changed == 'true' # run: ct lint --target-branch ${{ github.event.repository.default_branch }} # -# - name: Create kind cluster -# if: steps.list-changed.outputs.changed == 'true' -# uses: helm/kind-action@v1.10.0 + - name: Create kind cluster + uses: helm/kind-action@v1.10.0 + + - name: Setup Prerequisites + run: | + + echo "Deploying AKO" + curl -sL https://github.com/operator-framework/operator-lifecycle-manager/releases/download/v0.30.0/install.sh \ + | bash -s v0.30.0 + + kubectl create -f https://operatorhub.io/install/aerospike-kubernetes-operator.yaml + echo "Waiting for AKO" + while true; do + if kubectl --namespace operators get deployment/aerospike-operator-controller-manager &> /dev/null; then + kubectl --namespace operators wait \ + --for=condition=available --timeout=180s deployment/aerospike-operator-controller-manager + break + fi + done + + echo "Grant permissions to the target namespace" + kubectl create namespace aerospike + kubectl --namespace aerospike create serviceaccount aerospike-operator-controller-manager + kubectl create clusterrolebinding aerospike-cluster \ + --clusterrole=aerospike-cluster --serviceaccount=aerospike:aerospike-operator-controller-manager + + echo "Set Secrets for Aerospike Cluster" + kubectl --namespace aerospike create secret generic aerospike-secret \ + --from-literal=features.conf="$(echo "${{ secrets.FEATURES_CONF }}")" + # # - name: Run chart-testing (install) # if: steps.list-changed.outputs.changed == 'true' From bdc3ff516981de0b805697c13108ae15c151478f Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 16:47:08 +0200 Subject: [PATCH 05/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 109 +++++++++++++++++++- 1 file changed, 108 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 1e6e270..fba50a8 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -63,7 +63,114 @@ jobs: echo "Set Secrets for Aerospike Cluster" kubectl --namespace aerospike create secret generic aerospike-secret \ - --from-literal=features.conf="$(echo "${{ secrets.FEATURES_CONF }}")" + --from-literal=features.conf="$(echo "${{ secrets.FEATURES_CONF }}")" + + kubectl apply -f - <<-EOF + apiVersion: asdb.aerospike.com/v1 + kind: AerospikeCluster + metadata: + name: aerospike-cluster + namespace: aerospike + spec: + size: 1 + image: aerospike/aerospike-server-enterprise:7.0.0.5 + podSpec: + multiPodPerHost: true + storage: + filesystemVolumePolicy: + cascadeDelete: true + initMethod: deleteFiles + volumes: + - name: workdir + source: + persistentVolume: + storageClass: standard + volumeMode: Filesystem + size: 3Gi + aerospike: + path: /opt/aerospike + - name: nsvol1 + aerospike: + path: /mnt/disks/test + source: + persistentVolume: + storageClass: standard + volumeMode: Filesystem + size: 16G + - name: nsvol2 + aerospike: + path: /mnt/disks/avs-index + source: + persistentVolume: + storageClass: standard + volumeMode: Filesystem + size: 16G + - name: nsvol3 + aerospike: + path: /mnt/disks/avs-data + source: + persistentVolume: + storageClass: standard + volumeMode: Filesystem + size: 16G + - name: nsvol4 + aerospike: + path: /mnt/disks/avs-meta + source: + persistentVolume: + storageClass: standard + volumeMode: Filesystem + size: 16G + - name: aerospike-config-secret + source: + secret: + secretName: aerospike-secret + aerospike: + path: /etc/aerospike/secret + aerospikeConfig: + service: + feature-key-file: /etc/aerospike/secret/features.conf + # security: {} + network: + service: + port: 3000 + fabric: + port: 3001 + heartbeat: + port: 3002 + namespaces: + - name: test + replication-factor: 2 + storage-engine: + type: device + filesize: 17179869184 + files: + - /mnt/disks/test/test.dat + - name: avs-index + replication-factor: 2 + storage-engine: + type: device + filesize: 17179869184 + files: + - /mnt/disks/avs-index/avs-index.dat + - name: avs-data + replication-factor: 2 + storage-engine: + type: device + filesize: 17179869184 + files: + - /mnt/disks/avs-data/avs-data.dat + - name: avs-meta + nsup-period: 600 + nsup-threads: 2 + evict-tenths-pct: 5 + replication-factor: 2 + storage-engine: + type: device + filesize: 17179869184 + files: + - /mnt/disks/avs-meta/avs-meta.dat + EOF # # - name: Run chart-testing (install) From ec70d7685d131e6f6ab4e339a886b2fdb4d6822d Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 16:58:13 +0200 Subject: [PATCH 06/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index fba50a8..033df1e 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -25,17 +25,16 @@ jobs: check-latest: true - name: Set up chart-testing + if: startsWith(github.head_ref, 'VEC-') uses: helm/chart-testing-action@v2.6.1 - - name: Output default branch + - name: Run chart-testing (lint) + if: startsWith(github.head_ref, 'VEC-') run: | - echo "Branch: ${{ github.event.repository.default_branch }}" + ct lint --chart-dirs "./aerospike-vector-search" --target-branch ${{ github.event.repository.default_branch }} -# - name: Run chart-testing (lint) -# if: steps.list-changed.outputs.changed == 'true' -# run: ct lint --target-branch ${{ github.event.repository.default_branch }} -# - name: Create kind cluster + if: startsWith(github.head_ref, 'VEC-') uses: helm/kind-action@v1.10.0 - name: Setup Prerequisites @@ -172,7 +171,8 @@ jobs: - /mnt/disks/avs-meta/avs-meta.dat EOF -# -# - name: Run chart-testing (install) -# if: steps.list-changed.outputs.changed == 'true' -# run: ct install --target-branch ${{ github.event.repository.default_branch }} \ No newline at end of file + - name: Run chart-testing (install) + if: startsWith(github.head_ref, 'VEC-') + run: | + ct install --chart-dirs "./aerospike-vector-search" \ + --target-branch ${{ github.event.repository.default_branch }} From e284e333027ba337e55a11b35d2bdba2f0552aa4 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 17:02:50 +0200 Subject: [PATCH 07/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 033df1e..bb96794 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -25,16 +25,13 @@ jobs: check-latest: true - name: Set up chart-testing - if: startsWith(github.head_ref, 'VEC-') uses: helm/chart-testing-action@v2.6.1 - name: Run chart-testing (lint) - if: startsWith(github.head_ref, 'VEC-') run: | ct lint --chart-dirs "./aerospike-vector-search" --target-branch ${{ github.event.repository.default_branch }} - name: Create kind cluster - if: startsWith(github.head_ref, 'VEC-') uses: helm/kind-action@v1.10.0 - name: Setup Prerequisites @@ -172,7 +169,6 @@ jobs: EOF - name: Run chart-testing (install) - if: startsWith(github.head_ref, 'VEC-') run: | ct install --chart-dirs "./aerospike-vector-search" \ --target-branch ${{ github.event.repository.default_branch }} From ed31c17fcce6c5bf000103e266fef3e2cd77501a Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 17:10:34 +0200 Subject: [PATCH 08/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index bb96794..77653f7 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -29,7 +29,8 @@ jobs: - name: Run chart-testing (lint) run: | - ct lint --chart-dirs "./aerospike-vector-search" --target-branch ${{ github.event.repository.default_branch }} + cd aerospike-vector-search + ct lint --chart-dirs . --charts . --target-branch ${{ github.event.repository.default_branch }} - name: Create kind cluster uses: helm/kind-action@v1.10.0 From c81c69ea6385b330f304cfe895ce38e363bc2247 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 17:12:32 +0200 Subject: [PATCH 09/17] Update Chart.yaml --- aerospike-vector-search/Chart.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aerospike-vector-search/Chart.yaml b/aerospike-vector-search/Chart.yaml index b76eb38..559b5e9 100644 --- a/aerospike-vector-search/Chart.yaml +++ b/aerospike-vector-search/Chart.yaml @@ -1,5 +1,5 @@ apiVersion: v2 -name: aerospike-vector-search +name: aerospike-vector-search description: A Helm chart for Aerospike Vector Search type: application icon: https://avatars0.githubusercontent.com/u/2214313?s=200&v=4 @@ -11,7 +11,7 @@ maintainers: email: developers@aerospike.com # The helm chart version -version: 0.6.0 +version: 0.6.0 # The default version of Aerospike Vector Search appVersion: "0.11.1" From 4d9c3a22041fa19c8071ac41bdc8083d1105271d Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 17:17:34 +0200 Subject: [PATCH 10/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 77653f7..a1f04e2 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -171,5 +171,6 @@ jobs: - name: Run chart-testing (install) run: | - ct install --chart-dirs "./aerospike-vector-search" \ + cd aerospike-vector-search + ct install --namespace aerospike --chart-dirs . --charts . \ --target-branch ${{ github.event.repository.default_branch }} From 25ab60645fcb75cea35e7ade67a7dde4fda2dfd5 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 17:27:01 +0200 Subject: [PATCH 11/17] Update values.yaml --- aerospike-vector-search/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aerospike-vector-search/values.yaml b/aerospike-vector-search/values.yaml index 8d2fa70..4a5e307 100644 --- a/aerospike-vector-search/values.yaml +++ b/aerospike-vector-search/values.yaml @@ -74,7 +74,7 @@ aerospikeVectorSearchConfig: # - address: 10.0.0.1 # port: 5000 # TLS service port. - 5443: +# 5443: # Hostname/IP/network interface name to bind to. # If not specified binds to all interfaces. # addresses: From abc130f6b056e9a83233d07c632d015cee436b06 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 17:31:32 +0200 Subject: [PATCH 12/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index a1f04e2..92d243b 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -172,5 +172,5 @@ jobs: - name: Run chart-testing (install) run: | cd aerospike-vector-search - ct install --namespace aerospike --chart-dirs . --charts . \ + ct install --namespace aerospike --chart-dirs . \ --target-branch ${{ github.event.repository.default_branch }} From 13b5ab75fb33a476283160e289b9b6fd8eee6a32 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 18:02:34 +0200 Subject: [PATCH 13/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 92d243b..25d314d 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -27,15 +27,33 @@ jobs: - name: Set up chart-testing uses: helm/chart-testing-action@v2.6.1 + - name: Run chart-testing (list-changed) + id: list-changed + run: | + changed="$(ct list-changed --chart-dirs . --target-branch ${{ github.event.repository.default_branch }})" \ + | grep "aerospike-vector-search" + if [[ -n "$changed" ]]; then + echo "here" + echo "changed=true" >> "$GITHUB_OUTPUT" + fi + + - name: Run chart-testing (lint version bump) + if: steps.list-changed.outputs.changed == 'true' + run: | + ct lint --chart-dirs . --target-branch ${{ github.event.repository.default_branch }} + - name: Run chart-testing (lint) + if: steps.list-changed.outputs.changed == 'true' run: | cd aerospike-vector-search ct lint --chart-dirs . --charts . --target-branch ${{ github.event.repository.default_branch }} - name: Create kind cluster + if: steps.list-changed.outputs.changed == 'true' uses: helm/kind-action@v1.10.0 - name: Setup Prerequisites + if: steps.list-changed.outputs.changed == 'true' run: | echo "Deploying AKO" @@ -170,6 +188,7 @@ jobs: EOF - name: Run chart-testing (install) + if: steps.list-changed.outputs.changed == 'true' run: | cd aerospike-vector-search ct install --namespace aerospike --chart-dirs . \ From f09601d1cf59d6496b0e08a726fcc2d4faf49ee0 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 20:43:20 +0200 Subject: [PATCH 14/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 25d314d..8005f6f 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -17,7 +17,7 @@ jobs: - name: Set up Helm uses: azure/setup-helm@v4.2.0 with: - version: v3.14.4 + version: latest - uses: actions/setup-python@v5 with: @@ -30,8 +30,8 @@ jobs: - name: Run chart-testing (list-changed) id: list-changed run: | - changed="$(ct list-changed --chart-dirs . --target-branch ${{ github.event.repository.default_branch }})" \ - | grep "aerospike-vector-search" + changed="$(ct list-changed --chart-dirs . --target-branch ${{ github.event.repository.default_branch }} \ + | grep "aerospike-vector-search")" \ if [[ -n "$changed" ]]; then echo "here" echo "changed=true" >> "$GITHUB_OUTPUT" From a13140feb084ea916060b1da907471c553645530 Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 20:45:57 +0200 Subject: [PATCH 15/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 8005f6f..637b66c 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -31,7 +31,7 @@ jobs: id: list-changed run: | changed="$(ct list-changed --chart-dirs . --target-branch ${{ github.event.repository.default_branch }} \ - | grep "aerospike-vector-search")" \ + | grep "aerospike-vector-search")" if [[ -n "$changed" ]]; then echo "here" echo "changed=true" >> "$GITHUB_OUTPUT" From 931a9e1e81e6b4d7c2e79d40659c78a66d9fa50c Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 20:48:10 +0200 Subject: [PATCH 16/17] commit --- .github/workflows/lint-and-test-charts.yaml | 1 - aerospike-vector-search/Chart.yaml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 637b66c..9f7fa09 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -33,7 +33,6 @@ jobs: changed="$(ct list-changed --chart-dirs . --target-branch ${{ github.event.repository.default_branch }} \ | grep "aerospike-vector-search")" if [[ -n "$changed" ]]; then - echo "here" echo "changed=true" >> "$GITHUB_OUTPUT" fi diff --git a/aerospike-vector-search/Chart.yaml b/aerospike-vector-search/Chart.yaml index 559b5e9..809df67 100644 --- a/aerospike-vector-search/Chart.yaml +++ b/aerospike-vector-search/Chart.yaml @@ -11,7 +11,7 @@ maintainers: email: developers@aerospike.com # The helm chart version -version: 0.6.0 +version: 0.6.1 # The default version of Aerospike Vector Search appVersion: "0.11.1" From 0363c56c7e5b874b236721dcf8adaa3fcaff231d Mon Sep 17 00:00:00 2001 From: David Gerchikov Date: Wed, 20 Nov 2024 20:52:47 +0200 Subject: [PATCH 17/17] Update lint-and-test-charts.yaml --- .github/workflows/lint-and-test-charts.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/lint-and-test-charts.yaml b/.github/workflows/lint-and-test-charts.yaml index 9f7fa09..9411b81 100644 --- a/.github/workflows/lint-and-test-charts.yaml +++ b/.github/workflows/lint-and-test-charts.yaml @@ -1,10 +1,7 @@ name: Lint and Test Charts -#on: pull_request -on: - push: - branches: - - "VEC-430-configure-test-and-linting-for-all-helm-charts" +on: pull_request + jobs: lint-test: runs-on: ubuntu-latest