Zoom Bugfixes #22
Merged
Zoom Bugfixes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for handling zoom at very large scales, as well as clipping artifacts during dolly zoom.
After this change, you can now zoom out past the object the size of the observable universe, and the camera controller will be able to handle zoom limits at this scale without "latching" when floating point computations break down.
This also fixes a dolly zoom bug that has been annoying me forever, where the first frame would show an artifact with the meshes being clipped by the near plane. Turns out this was an ordering issue when receiving dolly zoom events.